Github user SudharmaJain commented on the issue:
https://github.com/apache/cloudstack/pull/1246
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user PranaliM commented on the issue:
https://github.com/apache/cloudstack/pull/1246
Test LGTM based on manual testing results.
Before fix The VM got a Netmask of 255.255.255.128 and after fix the VM got
a Netmask of 255.255.255.0
on a network where the CIDR was
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1246
### ACS CI BVT Run
**Sumarry:**
Build Number 419
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=2
Skipped=7
_Link to logs Folder
Github user SudharmaJain commented on the issue:
https://github.com/apache/cloudstack/pull/1246
@nlivens As suggested I have moved the getValidNetworkCidr to common class
NetworkModel.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sudhansu7 commented on the issue:
https://github.com/apache/cloudstack/pull/1246
LGTM for code change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1246
### ACS CI BVT Run
**Sumarry:**
Build Number 328
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=1
Skipped=7
_Link to logs Folder
Github user SudharmaJain commented on the issue:
https://github.com/apache/cloudstack/pull/1246
Moved the getValidNetworkCidr to common class NetworkModel and Rebased with
master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
