[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 Great, thanks @rhtyd! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks for your help @jburwell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1602 @serg38 @nvazquez I will merge this PR when I get into the office on Monday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 LGTM for the testing. Smoke test results ``` test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status : SUCCESS === Test listing Templates using 'ids' parameter ... === TestName: test_02_list_templates | Status : SUCCESS === Test listing Snapshots using 'ids' parameter ... === TestName:
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1602 Just realized I hadn't re-reviewed. LGTM for code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @karuturi @jburwell @rafaelweingartner Please disregard. We are still running tests for this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @karuturi @jburwell @rafaelweingartner Can you check if this PR can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 LGTM for testing [root@ussarlabcsmgt41 MarvinLogs]# cat /tmp//MarvinLogs/test_volumes_CP3Z7R/results.txt test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === ok test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === ok Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === ok Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === ok Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === ok Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === ok Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === ok Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === ok Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === ok Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === ok Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === ok Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === ok Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === ok Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === ok Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === ok Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === ok Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === ok Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === ok Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === ok Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === ok Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === ok Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === ok Test listing Volumes using 'ids' parameter ... === TestName:
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @jburwell for your review! I refactored based on your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1602 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1602 @rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1602 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1602 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1602 @rhtyd can you re-kick this PR for @blueorangutan? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 I rebased master branch and pushed again, could it be ran again? @blueorangutan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1602 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks guys. The code LGTM based on the code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @syed for your comments! I agree with @serg38 that extension to other hypervisors could be done in a separate PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. Absolutely it can although the effort seems to be well beyond and scope of this PR. @nvazquez and I have only access to vmware hypervisors at this point. If there is an interest to expand it let's open another PR focusing just on that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @serg38 my question is more along the lines of can this `fullClone`/ `linkedClone` functionality be extended to other hypervisors, in that case, we can make the code hypervisor agnostic. If not then I am happy with the current implementation as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. The default behavior won't change. The proposed enhancement will add an ability to control link/full clone deployment of a primary storage level. If it is not defined there a current value of a global setting will be applied. A global configuration setting vmware.create.full.clone is already in ACS starting from version 4.2 if I am not mistaken. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed adding to use cases that @serg38 mentioned, I edited PR's title which could be confusing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
