[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/826 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-214812658 I think we are all set. I will add to merge queue... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-214812261 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 ``` **Associated Uploads** **`/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_30_12_F4GNC9:`** * [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_30_12_F4GNC9/dc_entries.obj) * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_30_12_F4GNC9/failed_plus_exceptions.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/DeployDataCenter__Apr_25_2016_22_30_12_F4GNC9/runinfo.txt) **`/tmp/MarvinLogs/test_network_PROLMK:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_network_PROLMK/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_network_PROLMK/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_network_PROLMK/runinfo.txt) **`/tmp/MarvinLogs/test_vpc_routers_RCLMK9:`** * [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_vpc_routers_RCLMK9/failed_plus_exceptions.txt) * [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_vpc_routers_RCLMK9/results.txt) * [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR826/tmp/MarvinLogs/test_vpc_routers_RCLMK9/runinfo.txt) Uploads will be available until `2016-06-26 02:00:00 +0200 CEST` *Comment created by [`upr comment`](https://github.com/cloudops/upr).* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-213135751 @swill you know I always do; files from the server project have been changed. I would agree it is small and of low risk but I am not putting in the analysis to prove that nothing out of the ordinary can happen. So I'd say run the integration tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212963691 I am pretty comfortable with this change. We have had 2 manual tests to validate the functionality and two LGTM votes. I am not sure this change warrants a full run of the CI, but please give your feedback on this. @DaanHoogland do you have an opinion? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212836461 Tested these changes manually in my setup. Changes works fine. LGTM!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212800418 Tested the vpn user configuration with one router down and one router up and it is working fine. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212777128 @jayapalu attached the screenshots: https://cloud.githubusercontent.com/assets/4276209/14700575/17b9fb80-07be-11e6-84cb-b61d68816496.png;> https://cloud.githubusercontent.com/assets/4276209/14700581/1dcec636-07be-11e6-9794-b359a4fd47d3.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212773238 @jayapalu Rebased. Please have a look now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-212754742 @kansal Can you rebase it once. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-143727275 @remibergsma Rebased against the master. Repro steps are as follows: 1) Create two VMs in new isolated networks, testnet1 and testnet2. 2) Enable VPN in testnet1 and testnet2. 3) Add a VPN user in each network. 4) Notice that VPN users added. 5) Stop the VR for testnet2. 6) Add a VPN user in testnet1. 7) Notice that it fails with an error even though the testnet1 VR is running. The reason it is failing is that presently we there is only a check for the running VR's. If not running then error is thrown. Based on the present implementation of the VR rules, we should skip the STOPPED/STOPPING VR's as the rules get applied to them after they get restarted. To check rules are applied(VPN in this case), ssh to the NOW running VR and look into the /usr/share/ppp/chap-secrets file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-143590180 @kansal Thanks! Can you please rebase against current master? Then we can run the tests. How did you test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-141897458 @jayapalu can you review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
