Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-18 Thread Suresh Kumar Anaparti
t; If there are any objections or bugs, please share in which case we'll > > revert the change to continue legacy/historic behaviour. Thanks. > > > > > > - Rohit > > > > <https://cloudstack.apache.org> > > > > > > > > ___

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-16 Thread Marc-Aurèle Brothier
ending tasks to complete > such tasks always fail. > > > - Rohit > > <https://cloudstack.apache.org> > > > > > From: Suresh Kumar Anaparti <sureshkumar.anapa...@gmail.com> > Sent: Wednesday, May 16, 2018 4:27:36 PM > To: dev@cloudstack.a

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-16 Thread Rohit Yadav
6 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection? Hi Rohit, When Management Server and Agent are up and running and there is a network failure, I think it is better to wait for some time for the pending tasks to compl

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-16 Thread Suresh Kumar Anaparti
lue.com> > Sent: Tuesday, May 15, 2018 2:37:58 PM > To: dev@cloudstack.apache.org > Subject: Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt > server) disconnection? > > Hi Suresh, > > > I've replied to your comment on the PR. In addition, when (i) managem

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-16 Thread Rohit Yadav
ent: Tuesday, May 15, 2018 2:37:58 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection? Hi Suresh, I've replied to your comment on the PR. In addition, when (i) management server is restarted any pending operation on KV

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-15 Thread Rohit Yadav
Subject: Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection? Hi, @rhtyd, I checked the PR changes. Good that the agent is not waiting for the pending jobs and retrying connection to management server. This might have impact on ssvm and kvm agent tasks, not much

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Suresh Kumar Anaparti
> > pending async jobs on a mgmg server to complete and does not take any new > > async/job API requests (say like Jenkins does with jobs)? > > > > > > Marc - were n't you working on a zookeeper based rolling > shutdown/restart? > > Did that handle some of the fail

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Marc-Aurèle Brothier
working on a zookeeper based rolling shutdown/restart? > Did that handle some of the failure cases? > > > - Rohit > > <https://cloudstack.apache.org> > > > > ________________ > From: Marc-Aurèle Brothier <ma...@exoscale.ch> > Sent: Monday, May

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Rohit Yadav
some of the failure cases? - Rohit <https://cloudstack.apache.org> From: Marc-Aurèle Brothier <ma...@exoscale.ch> Sent: Monday, May 14, 2018 4:06:56 PM To: dev@cloudstack.apache.org Subject: Re: [DISCUSS][ASK] Should agent wait for pending ta

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-14 Thread Marc-Aurèle Brothier
Hi, I'm also for a bigger change but this PR already moves forward to a better agent <-> management connection hanlding. @rhtyd did you test your PR manually by, for example, requesting a long snapshot operation and disconnecting the agent. I have one concern here: when an async job is taken

Re: [DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-12 Thread Rafael Weingärtner
Would prefer “A bigger design fix would be to make management server asynchronous of agent side answer/response handling”. However, I understand the volume of changes that requires. I looked at the PR, and I think that everything is ok there. Of course, I think we might need some more time to

[DISCUSS][ASK] Should agent wait for pending tasks on (mgmt server) disconnection?

2018-05-11 Thread Rohit Yadav
All, Historically, when the agent (kvm, ssvm, cpvm) is disconnected from the management server (say due to mgmt server restart etc), the reconnection logic waits for any pending tasks/commands to complete before reconnection attempts are made. I tried to search git history but could not find