Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-28 Thread Wido den Hollander
nt: Thursday, July 27, 2017 5:47:39 PM > To: Syed Ahmed; dev@cloudstack.apache.org > Cc: Marc-Aurèle Brothier > Subject: Re: [DISCUSS] Closing old Pull Requests on Github > > > > Op 27 juli 2017 om 17:13 schreef Syed Ahmed <sah...@cloudops.com>: > > > > > &

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-27 Thread Rohit Yadav
2017 5:47:39 PM To: Syed Ahmed; dev@cloudstack.apache.org Cc: Marc-Aurèle Brothier Subject: Re: [DISCUSS] Closing old Pull Requests on Github > Op 27 juli 2017 om 17:13 schreef Syed Ahmed <sah...@cloudops.com>: > > > I would start by adding a comment to the open PRs to see if th

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-27 Thread Wido den Hollander
> Op 27 juli 2017 om 17:13 schreef Syed Ahmed : > > > I would start by adding a comment to the open PRs to see if the author is > responsive. If that's the case, then it means that review is need and we > can add the "waiting-for-review" tag. There are a few PRs that are in

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-27 Thread Syed Ahmed
I would start by adding a comment to the open PRs to see if the author is responsive. If that's the case, then it means that review is need and we can add the "waiting-for-review" tag. There are a few PRs that are in that state but there are far more out there which need to have this tag added.

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-24 Thread Wido den Hollander
> Op 24 juli 2017 om 10:47 schreef Marc-Aurèle Brothier : > > > Hi Wido, > > I have one comment on this topic. Some of those PRs are lying there because > no one took the time to merge them (I have a couple like that) since they > were not very important (I think it's the

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-24 Thread Rohit Yadav
; Sent: Monday, July 24, 2017 10:22:28 AM To: dev@cloudstack.apache.org Subject: [DISCUSS] Closing old Pull Requests on Github Hi, While writing this e-mail we have 191 Open Pull requests [0] on Github and that number keeps hovering around ~200. We have a great number of PRs being merged, but

Re: [DISCUSS] Closing old Pull Requests on Github

2017-07-24 Thread Marc-Aurèle Brothier
Hi Wido, I have one comment on this topic. Some of those PRs are lying there because no one took the time to merge them (I have a couple like that) since they were not very important (I think it's the reason), fixing only a small glitch or improving an output. If we start to close the PRs because

[DISCUSS] Closing old Pull Requests on Github

2017-07-24 Thread Wido den Hollander
Hi, While writing this e-mail we have 191 Open Pull requests [0] on Github and that number keeps hovering around ~200. We have a great number of PRs being merged, but a lot of code is old and doesn't even merge anymore. My proposal would be that we close all PRs which didn't see any activity