[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain

2020-07-03 Thread GitBox 


ravening commented on pull request #459:
URL: 
https://github.com/apache/cloudstack-primate/pull/459#issuecomment-653551845


   > @ravening This looks good, can you treat -1 as unlimited and display it 
accordingly?
   
   @davidjumani I didnt see "-1" in the output of listDomains or listAccounts 
or listProjects. It returns "Unlimited" instead of -1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain

2020-07-02 Thread GitBox 


ravening commented on pull request #459:
URL: 
https://github.com/apache/cloudstack-primate/pull/459#issuecomment-652922816


   @rhtyd I made the proper changes showing progress bar as well for 
Domains/accounts/projects
   Please review again
   
   ![Screenshot 2020-07-02 at 12 21 
37](https://user-images.githubusercontent.com/10645273/86347439-9589b880-bc5e-11ea-999a-a34b966bf929.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] ravening commented on pull request #459: Display tab showing the current resource count for domain

2020-06-29 Thread GitBox 


ravening commented on pull request #459:
URL: 
https://github.com/apache/cloudstack-primate/pull/459#issuecomment-651207536


   > @ravening here are some feedback and ideas:
   > 
   > * Rename the tab to Resource or something like Usage?
   > * Could you make it reusable, as it's the same concept for account and 
projects (similar to the limits tab)
   > * If we need to show the current resource count/usage in a different tab, 
remove it from the details tab (do it for accounts and projects as well)
   > * See Infra -> zone -> resources tab which shows capacities/resource count 
for zones; you may even show progress bar like widgets (we know current and 
total usage, to show a percentage for example)
   
   @rhtyd 
   Im not sure how to display the progress bar properly as most of the 
resources will be "-1" for root domain and other domains. In that case what 
value should I use for denominator?
   
   In the details tab they just iterate over the values in the array. So it 
might be difficult to remove the details from there



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org