[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @mlsorensen We can indeed do that, but the good thing for now is that the RNG is disabled by default. You also need a very ancient libvirt for it not to support RNG and that will get less and less over time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user mlsorensen commented on the issue: https://github.com/apache/cloudstack/pull/1572 I realize I'm late to the party on this, but I'd like to suggest that we change from the agent.properties "vm.rng.enable=true" to simply using the libvirt version detection like we do for other things, and perhaps allow a "vm.rng.disable". It really seems like this is a useful setting and should probably be default wherever possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 @rhtyd my point is that, even if its run on KVM, this functionality wont be covered with existing tests. I agree to your point. It was just that I had xen tests available and another run on KVM would take huge amount of effort from my side and at the end wont test the new functionality. Thanks for the email. will go through. I went through the commits on #1692. It has two bug fixes(CLOUDSTACK-9515, CLOUDSTACK-9533) and some test fixes. I dont see why its a blocker for commits to master. (probably the mail has some context. will go through) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi I think it beats the purpose of smoke tests if we don't run them against the hypervisor(s) the PR/change is most likely related to. Without valid test results it is hard to validate a change/PR, the guideline was to have two LGTMs and at least one test result/run though I agree any committer should be able to merge a PR. This is the email thread you're looking for: http://markmail.org/message/xp7ckhxhip2rbnr7 For the past two weeks several of us are trying to fix tests/issues and get most of the smoke tests pass on all three major hypervisors. You may follow that effort on PR #1692 and #1703 that uses Trillian (https://github.com/shapeblue/Trillian). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 1. the current set of integration tests doesnt test the new functionality added in this PR. Its merely a check to see nothing else is broken. 2. when did we freeze? I skimmed through the mails didnt see anything about master frozen. I do not see any blocker defects for 4.10.0.0. The latest understanding I have is anybody can merge with required code LGTMs and a BVT run. 3. Which smoke tests are broken? Is it you environment issue you are talking about? If not, are these new or did we release 4.9.0 with these broken tests/features? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi am I missing the test results on this PR for the enhancements? All I see are tests against XenServer which have no bearing on this change. Why was this PR merged without a full run against KVM and while we are frozen to fix the smoke test suite? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1572 code LGTM ð from @ustcweizhou and there are test runs I am merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Can I get a review on this one so it can be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 No LGTM on this one yet. Are we good @ustcweizhou and @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1572 ### ACS CI BVT Run **Sumarry:** Build Number 203 Hypervisor xenserver NetworkType Advanced Passed=71 Failed=2 Skipped=3 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_vpc_vpn.py * ContextSuite context=TestRVPCSite2SiteVpn>:setup Failing since 23 runs * test_volumes.py * test_06_download_detached_volume Failed **Skipped tests:** test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_routers.py test_reset_vm_on_reboot.py test_snapshots.py test_deploy_vms_with_varied_deploymentplanners.py test_login.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Did you get a chance to take a look @remibergsma ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1572 Thanks @wido will have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Ok, thanks @ustcweizhou . Could you take a technical look and see if you LGTM? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido thanks. it sound fine to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @remibergsma: Could you check again? You can now set the rate with period and bytes to prevent exhaustion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @ustcweizhou Using 'vm.rng.enable=true' you can enable or disable the RNG. This controls if the XML is generated or not. This is set to false by default, so it will work on Ubuntu 12.04 without any problems as long as you don't enable it. Ubuntu 12.04 is however still way to old and is using a ancient Java version. So Ubuntu 12.04 will become unsupported anyway in the near future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido , thanks for your reply. As I know, there are still many people using Ubuntu 12.04. Especially for one starting using CloudStack/Ubuntu 2-3 years ago ( before Ubuntu 14.04 release), it is difficult for them to (live) upgrade their production to CloudStack 4.9/Ubuntu 14.04 or 16.04. I think it is better to be compatible with Ubuntu 12.04, by disabling the feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 Yes, valid point @remibergsma , see: https://libvirt.org/formatdomain.html#elementsRng I'll add support so that you can configure: `` `` That way you can prevent the guest from exhausting the HV. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1572 @wido Thanks for the feature, I like it! Although I'm a bit worried that many VMs could potentially exhaust the hypervisor's `/dev/random`? How do you handle that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
