[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-09 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1584 Cool, thanks @swill! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-09 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 Ok, thanks guys. I will get this merged into 4.9. Thank you for the bug report and fix... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-09 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1584 Thanks @rhtyd for this fix! Just for the record, this was error before this fix: 2016-06-07 11:04:51,233 ERROR [cloud.usage.UsageManagerImpl] (Usage-Job-1:null) (logid

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1584 LGTM based on the code review. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 I would like to get at least one review of this before we merge it. @nvazquez would you be able to review this? --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 Reran the test that failed that was not expected to fail and it passed now. I think we are good to go here... --- If your project is set up for it, you can reply to this email and have your repl

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 ### CI RESULTS ``` Tests Run: 4 Skipped: 0 Failed: 0 Errors: 0 Duration: 0h 18m 33s ``` **Associated Uploads** **`/tmp

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 I ran all of the usage tests against this PR. The last two errors have always happened on this setup for me, so I don't think they are related to this test. The first one looks like a cleanup is

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1584 ### CI RESULTS ``` Tests Run: 103 Skipped: 0 Failed: 1 Errors: 2 Duration: 4h 39m 38s ``` **Summary of the problem(s):** ``` FAIL

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 @nvazquez I've tested and with this fix unable to reproduce your issue, can you help review and test this PR? Thanks. --- If your project is set up for it, you can reply to this email and have yo