[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-11-20 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1603 @romain-dartigues can you fix the conflicts thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-12 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 Done. Le me know what you think about it (I don't think Jenkins failed because of my edits?). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-06 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 OK, will get back on it during the week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1603 @romain-dartigues can you rebase against latest master and push -f? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-07-05 Thread The-Loeki
Github user The-Loeki commented on the issue: https://github.com/apache/cloudstack/pull/1603 Hi :) sorry I was unable to process your request to merge your PR with mine, as you can probably tell by now this would've oversized & muddied both PR's ;) Depending on the uptake of the

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-07-05 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 Hi @The-Loeki, and thank you for your prompt comment! For your side notes: * this is mostly a preference, I don't care what you use but here are my argument for the

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-07-05 Thread The-Loeki
Github user The-Loeki commented on the issue: https://github.com/apache/cloudstack/pull/1603 kudos for all the hard work! Most of this should've been done a long time ago as `pylint` is one of the first firewalls of code quality ensurance. Side notes: * no fan of `%s`