[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-09-01 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-09-01 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@milamberspace I am trying to get this PR merged, but am running into some 
issues the git-pr script.  I am working with @rhtyd to figure out what I am 
doing wrong.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-09-01 Thread milamberspace
Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@jburwell @rhtyd Since #1654 has been merged. Travis and Jenkins tests have 
passed. Ready to merge this small PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-30 Thread milamberspace
Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
Thanks for reply @rhtyd I will wait the merge of #1654 before force to 
re-check this PR by travis/jenkins


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-29 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@jburwell @milamberspace due to version change in poms already merged on 
4.8 without a valid db upgrade path (which I had added in a separate PR), we'll 
see db failures for all PRs targeting 4.8 branch. Please fix and merge #1654  
first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-28 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@milamberspace could you add a JIRA ticket for this issue and prefix the 
title of the commit message and PR title with the ID?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-28 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@rhtyd do you any insight about the database schema issue @milamberspace is 
encountering in the Travis build?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-23 Thread milamberspace
Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  

@jburwell I repush with force, but the build error still alive on Travis
"> Processing SQL file at 
/home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql

Unable to execute 
/home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql:
 Unknown column 'state' in 'field list'"

I suppose it's an issue on 4.8 branch? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

2016-08-22 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@milamberspace the Jenkins build build failed.  Could you please force push 
the change to trigger another attempt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---