[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 Thanks @serg38 @abhinandanprateek for the review. With enough lgtms and (manual) test result against a large pre-4.1 db, I'll proceed with merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1656 LGTM on code review, the fix is taking care of the removed column, thereby maintaining the constraints. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 There are no upgrade tests to confirm the fix as all the changes are in an older 4.1.0->4.2.0 upgrade path. After this fix, here are manual test results to show that db upgrade finished cleanly without breaking with foreign key constraint issue: > 2016-08-23 13:55:06,886 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Migrating secondary storage to image store > 2016-08-23 13:55:06,896 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Checking if we need to migrate NFS secondary storage to image store or staging store > 2016-08-23 13:55:06,896 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Migrating NFS secondary storage to Image store > 2016-08-23 13:55:06,921 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Marking NFS secondary storage in host table as removed > 2016-08-23 13:55:06,934 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Completed migrating secondary storage to image store > 2016-08-23 13:55:06,934 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Updating volume_store_ref table from volume_host_ref table > 2016-08-23 13:55:06,957 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Insert modified 22 rows > 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Update modified 0 rows > 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Completed updating volume_store_ref table from volume_host_ref table > 2016-08-23 13:55:06,958 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Updating template_store_ref table from template_host_ref table > 2016-08-23 13:55:07,445 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Insert modified 6622 rows > 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Update modified 3666 rows > 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Completed updating template_store_ref table from template_host_ref table > 2016-08-23 13:55:07,479 DEBUG [c.c.u.d.Upgrade410to420] (main:null) (logid:) Updating snapshot_store_ref table from snapshots table --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 @jburwell fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1656 @rhtyd would it be possible to re-target this PR to the 4.8 branch? It seems like a good fix to include in 4.8.2.0 as well as 4.9.1.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1656 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1656 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1656 Job ID-99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1656 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1656 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
