[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1697 I think the conflicts were on VolumeOrchestrator.java and TemplateManagerImplTest.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1697 @karuturi do you happen to remember which files conflicted? I seem to remember VolumeOrchestrator.java having some changes in master that weren't in 4.9. I've looked over all of the files that were touched in this PR and it all looks good to me. Thanks for merging this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1697 @nathanejohnson @kiwiflyer There were some conflicts while merging to master. I went ahead and resolved as they are minor conflicts. Please verify that everything is fine on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1697 merging this to 4.9+ branches --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1697 LGTM Tested it, works as expected! Was confused a bit, but it works fine on KVM. It seems `XenserverSnapshotStrategy` is also used to handle KVM snapshots. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 Packaging result: âcentos6 âcentos7 âdebian. JID-200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1697 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 Trillian test result (tid-290) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36987 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1697-t290-vmware-55u3.zip Test completed. 45 look ok, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_site2site_vpn | `Error` | 506.04 | test_vpc_vpn.py ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 737.80 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Error` | 1133.45 | test_privategw_acl.py test_01_vpc_remote_access_vpn | Success | 171.27 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 377.16 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 740.29 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 732.72 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1582.80 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 887.91 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | Success | 717.44 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1382.11 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 30.86 | test_volumes.py test_06_download_detached_volume | Success | 55.42 | test_volumes.py test_05_detach_volume | Success | 105.26 | test_volumes.py test_04_delete_attached_volume | Success | 10.15 | test_volumes.py test_03_download_attached_volume | Success | 20.24 | test_volumes.py test_02_attach_volume | Success | 59.34 | test_volumes.py test_01_create_volume | Success | 524.21 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.31 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 227.04 | test_vm_snapshots.py test_01_test_vm_volume_snapshot | Success | 311.74 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 167.21 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 282.99 | test_vm_life_cycle.py test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 46.82 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.17 | test_vm_life_cycle.py test_08_migrate_vm | Success | 80.82 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.07 | test_vm_life_cycle.py test_06_destroy_vm | Success | 10.14 | test_vm_life_cycle.py test_03_reboot_vm | Success | 10.12 | test_vm_life_cycle.py test_02_start_vm | Success | 30.25 | test_vm_life_cycle.py test_01_stop_vm | Success | 10.12 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 306.61 | test_templates.py test_08_list_system_templates | Success | 0.02 | test_templates.py test_07_list_public_templates | Success | 0.03 | test_templates.py test_05_template_permissions | Success | 0.04 | test_templates.py test_04_extract_template | Success | 20.25 | test_templates.py test_03_delete_template | Success | 5.08 | test_templates.py test_02_edit_template | Success | 90.08 | test_templates.py test_01_create_template | Success | 160.92 | test_templates.py test_10_destroy_cpvm | Success | 271.72 | test_ssvm.py test_09_destroy_ssvm | Success | 268.45 | test_ssvm.py test_08_reboot_cpvm | Success | 156.53 | test_ssvm.py test_07_reboot_ssvm | Success | 158.12 | test_ssvm.py test_06_stop_cpvm | Success | 176.56 | test_ssvm.py test_05_stop_ssvm | Success | 173.29 | test_ssvm.py test_04_cpvm_internals | Success | 1.05 | test_ssvm.py test_03_ssvm_internals | Success | 3.40 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.11 | test_ssvm.py test_01_snapshot_root_disk | Success | 31.01 | test_snapshots.py test_04_change_offering_small | Success | 97.42 | test_service_offerings.py test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py test_01_create_service_offering | Success | 0.08 | test_service_offerings.py test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.13 | test_secondary_storage.py test_09_reboot_router | Success | 155.80 | test_routers.py test_08_start_router | Success | 135.72 | test_routers.py test_07_stop_router | Success | 20.16 | test_routers.py test_06_router_advanced | Success | 0.04 | test_routers.py test_05_router_basic | Success | 0.03 |
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1697 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 Packaging result: âcentos6 âcentos7 âdebian. JID-141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1697 Looks like intermittent build issue, I'll re-fire builds. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1697 @blueorangutan could you send logs? I just verified that I could build a centos 7 rpm from this branch, can't reproduce the failure. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 Packaging result: âcentos6 âcentos7 âdebian. JID-137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1697 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1697 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1697 @syed This is the PR we discussed on the call today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1697 @nathanejohnson we making a hard push on #1692 to get all of the smoke tests to be super green. Once that PR is merged up, we will rebase and re-test this PR and there will be no more expected/"good" failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1697 Here are results running the following tests: component/test_snapshots.py component/test_snapshots_improvement.py component/test_snapshot_gc.py component/test_snapshot_limits.py on a KVM host using Ceph as primary and NFS as secondary: https://gist.github.com/nathanejohnson/38805b23a67d512e5051a0390ca5294c The failures look to be what you would expect, complaining mostly about snapshots not being backed up to secondary when that's precisely the behavior we're after. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1697 @jburwell @kiwiflyer @bvbharatk This is the new PR, I will post test results soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
