[GitHub] cloudstack issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in V...

2017-03-22 Thread niteshsarda
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1850 I have tested this and LGTM for test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] cloudstack issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in V...

2017-03-08 Thread sudhansu7
Github user sudhansu7 commented on the issue: https://github.com/apache/cloudstack/pull/1850 @koushik-das Added marvin test. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] cloudstack issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in V...

2016-12-29 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1850 Code changes LGTM. Can you add some unit/marvin tests for the scenario that you have mentioned? --- If your project is set up for it, you can reply to this email and have your reply appear