Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@koushik-das as a RM I want to ensure that all changes, irrespective of
their size, are merged after a QA process.
For UI/translation/docs changes tests are not necessary. Please
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd If you had checked #1812 you wouldn't have asked these questions :)
This config was introduced in #1812 and the scope was incorrectly put as
zone, the config is meant to be a
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@koushik-das there are no test results on this PR, also can you explain why
you've removed the option to override this setting at the zone level?
---
If your project is set up for it, you can
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@rhtyd Tests are present in #1812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@koushik-das there are no tests, Java related code changes ought to require
regression tests, even if it may appear to not need them. Let's not work
towards degrading the branch health.
---
If
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1899
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1899
LTGM
smoke test is not necessary
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1899
@ustcweizhou please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
