[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM, @karuturi can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user kiwiflyer commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM from borisstoyanov in a commit comment (acspr) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1948 Great, nice work. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user stefaniabergljot commented on the issue: https://github.com/apache/cloudstack/pull/1948 @rafaelweingartner It's not, but you can treat IPNetwork like it's a standard list object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1948 @ProjectMoon may I ask you a question? The "net" object is already an array/map, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1948 Trillian test result (tid-870) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33543 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1948-t870-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Test completed. 47 look ok, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 874.34 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.02 | test_vpc_redundant.py test_04_rvpc_privategw_static_routes | `Failure` | 330.77 | test_privategw_acl.py test_01_vpc_site2site_vpn | Success | 160.11 | test_vpc_vpn.py test_01_vpc_remote_access_vpn | Success | 66.25 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | Success | 250.97 | test_vpc_vpn.py test_02_VPC_default_routes | Success | 298.25 | test_vpc_router_nics.py test_01_VPC_nics_after_destroy | Success | 526.31 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | Success | 506.37 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | Success | 1402.83 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 566.05 | test_vpc_redundant.py test_09_delete_detached_volume | Success | 151.61 | test_volumes.py test_08_resize_volume | Success | 156.45 | test_volumes.py test_07_resize_fail | Success | 161.63 | test_volumes.py test_06_download_detached_volume | Success | 156.41 | test_volumes.py test_05_detach_volume | Success | 156.70 | test_volumes.py test_04_delete_attached_volume | Success | 151.31 | test_volumes.py test_03_download_attached_volume | Success | 151.39 | test_volumes.py test_02_attach_volume | Success | 96.19 | test_volumes.py test_01_create_volume | Success | 717.60 | test_volumes.py test_03_delete_vm_snapshots | Success | 275.60 | test_vm_snapshots.py test_02_revert_vm_snapshots | Success | 95.63 | test_vm_snapshots.py test_01_create_vm_snapshots | Success | 163.89 | test_vm_snapshots.py test_deploy_vm_multiple | Success | 248.34 | test_vm_life_cycle.py test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py test_10_attachAndDetach_iso | Success | 26.72 | test_vm_life_cycle.py test_09_expunge_vm | Success | 125.27 | test_vm_life_cycle.py test_08_migrate_vm | Success | 30.86 | test_vm_life_cycle.py test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py test_06_destroy_vm | Success | 125.98 | test_vm_life_cycle.py test_03_reboot_vm | Success | 125.88 | test_vm_life_cycle.py test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py test_01_stop_vm | Success | 40.40 | test_vm_life_cycle.py test_CreateTemplateWithDuplicateName | Success | 40.55 | test_templates.py test_08_list_system_templates | Success | 0.03 | test_templates.py test_07_list_public_templates | Success | 0.04 | test_templates.py test_05_template_permissions | Success | 0.08 | test_templates.py test_04_extract_template | Success | 5.17 | test_templates.py test_03_delete_template | Success | 5.11 | test_templates.py test_02_edit_template | Success | 90.18 | test_templates.py test_01_create_template | Success | 45.46 | test_templates.py test_10_destroy_cpvm | Success | 191.69 | test_ssvm.py test_09_destroy_ssvm | Success | 133.65 | test_ssvm.py test_08_reboot_cpvm | Success | 101.59 | test_ssvm.py test_07_reboot_ssvm | Success | 133.57 | test_ssvm.py test_06_stop_cpvm | Success | 131.89 | test_ssvm.py test_05_stop_ssvm | Success | 163.73 | test_ssvm.py test_04_cpvm_internals | Success | 1.22 | test_ssvm.py test_03_ssvm_internals | Success | 4.20 | test_ssvm.py test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py test_01_snapshot_root_disk | Success | 11.34 | test_snapshots.py test_04_change_offering_small | Success | 210.37 | test_service_offerings.py test_03_delete_service_offering | Success | 0.06 | test_service_offerings.py test_02_edit_service_offering | Success | 0.07 | test_service_offerings.py test_01_create_service_offering | Success | 0.11 | test_service_offerings.py test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py test_09_reboot_router | Success | 35.30 | test_routers.py test_08_start_router | Success | 30.29 | test_routers.py test_07_stop_router | Success | 10.17 | test_routers.py
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1948 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1948 @borisstoyanov cloud-scripts tarball in the systemvm.iso will have the router/scripts. We can test it. @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1948 Thanks, @ProjectMoon I cannot run tests against it since we don't have an automated way to build the systemVM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check
Github user ProjectMoon commented on the issue: https://github.com/apache/cloudstack/pull/1948 Updated with the JIRA ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
