Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-222495165
Master is currently frozen for the 4.9 release. Only fixes that stabilize
master are to be added at this point.
---
If your project is set up for it, you can reply
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-222488422
@swill , recent CI run on this PR shows 0 Failures. Can you please merge
this?
---
If your project is set up for it, you can reply to this email and have your
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-11023
### ACS CI BVT Run
**Sumarry:**
Build Number 66
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=0
Skipped=3
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132
The additional run of these tests in a new environment gives the same
results. I think this needs some work still...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982
The added test fails, but lots of tests failed. I will rebuild my
environment and test again to see if anything changes.
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641
### CI RESULTS
```
Tests Run: 7
Skipped: 0
Failed: 4
Errors: 0
Duration: 0h 37m 50s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216560467
Thank you @sanju1010, I will get this in for testing again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216524259
@swill , added check to see if m has any match object and fail if not.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216219841
@sanju1010 please rebase and push -f for travis job to be kicked off
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215309683
Thanks @swill , I will fix the error and update the PR. Thanks for taking
your time and running it on your CI.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215224845
Don't worry about the connectivity issues, that seems to be my environment
right now. The ERROR you do need to fix because that is a problem. Cheers...
---
If
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1304#discussion_r61333278
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2683,6 +2687,65 @@ def setUp(self):
def tearDown(self):
return
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-215221441
### CI RESULTS
```
Tests Run: 92
Skipped: 0
Failed: 4
Errors: 1
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-214538838
Running tests again in the same setup to see if any of the connection
issues are resolved. The error for sure should be looked into...
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-214537887
### CI RESULTS
```
Tests Run: 29
Skipped: 10
Failed: 3
Errors: 1
```
**Summary of the problem(s):**
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-214503490
Would you mind doing a force push to try to get everything green. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-213448269
I have made changes as per @pavanb018's comments and tested it on my
environment.
Following are the test results:
Test restart network with cleanup ...
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-212934000
@sanju1010 can you review @pavanb018's comment.
We need 1 more LGTM code review, otherwise things are looking to be in
pretty good shape here.
---
If your
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-212892204
Done code review ,a part from the above comment , the code LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user pavanb018 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1304#discussion_r60570371
--- Diff: test/integration/component/test_vpc_network.py ---
@@ -2748,3 +2751,86 @@ def test_stop_start_vpc_router(self):
if
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-202117240
### ACS CI BVT Run
**Sumarry:**
Build Number 136
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=0
Skipped=4
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-168653437
Test restart network with cleanup ... === TestName:
test_restart_network_with_cleanup | Status : SUCCESS ===
ok
GitHub user sanju1010 opened a pull request:
https://github.com/apache/cloudstack/pull/1304
[CLOUDSTACK-9207] Test to verify restarting vpc network with cleanup does
not delete the secondary ip address from VR
Please check jira
23 matches
Mail list logo
