Github user sverrirab closed the pull request at:
https://github.com/apache/cloudstack/pull/1526
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1495
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-219123470
I think we should merge this one at this point. @sverrirab my
understanding is that once #1533 is merged, this will be required. If that is
the case, when this one
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-219001342
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-218959080
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1526#issuecomment-216248435
You can close this PR. Once #1495 is merged, it will be forward merged
into 4.8 and master, so this PR is not needed. Thanks... :)
---
If your project is set up
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-216233064
Created new PR on master: https://github.com/apache/cloudstack/pull/1526
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1526
Add perl-modules as install dependency for cloudstack-agent
Required to run perl scripts that configure networking for VMs.
That script fails silently if this is not installed.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-216228633
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-214813960
As this is a bug fix, I think it would be forward-merged into master. The
next PR should be to rewrite the script in Python instead of Perl, and that
would be
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-214783340
do you want this change as a new PR against master or just the rewritten
script in python on master?
---
If your project is set up for it, you can reply to this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-214735227
If this is broken right now and this fixes it, LGTM. But we should really
ditch Perl and rewrite in Python or Bash.
Can you afterwards submit a PR against
Github user sverrirab commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-210485675
I agree that this is not a good approach but it is the current one and it
is broken. How about we commit this fix and I submit a new PR to master with a
new
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-210018290
@sverrirab how much effort would it be to port to Python? That seems far
preferable for two reasons. First, as @eriweb rightly points out, it is a
large
Github user eriweb commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-210016535
Quite horribly that we need those modules for a simple perl script of 58
lines (including license header and empty lines). Not related to your PR
though, but a good
GitHub user sverrirab opened a pull request:
https://github.com/apache/cloudstack/pull/1495
Add perl-modules as install dependency for cloudstack-agent
Required to run perl scripts that configure networking for VMs.
You can merge this pull request into a Git repository by running:
16 matches
Mail list logo
