[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

Github user sverrirab closed the pull request at:

https://github.com/apache/cloudstack/pull/1526


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1495


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-219123470
  
I think we should merge this one at this point.  @sverrirab my 
understanding is that once #1533 is merged, this will be required.  If that is 
the case, when this one is merged, maybe you can work into that PR the 
reverting of this PR.  Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-219001342
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-218959080
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1526#issuecomment-216248435
  
You can close this PR.  Once #1495 is merged, it will be forward merged 
into 4.8 and master, so this PR is not needed.  Thanks...  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

Github user sverrirab commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-216233064
  
Created new PR on master: https://github.com/apache/cloudstack/pull/1526


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

GitHub user sverrirab opened a pull request:

https://github.com/apache/cloudstack/pull/1526

Add perl-modules as install dependency for cloudstack-agent

Required to run perl scripts that configure networking for VMs.
That script fails silently if this is not installed.

As requested here: https://github.com/apache/cloudstack/pull/1495

Another PR will be submitted with the module written in python to remove 
this dependency...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-master-agent-perl-modules-install

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1526


commit c70802fde9f170046118f977bd7ee856205e2064
Author: Sverrir Berg 
Date:   2016-04-13T16:48:31Z

Add perl-modules as install dependency for cloudstack-agent

Required to run perl scripts that configure networking for VMs.
That script fails silently if this is not installed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-216228633
  
tag:easypr


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[ProjectMoon]

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-214813960
  
As this is a bug fix, I think it would be forward-merged into master. The 
next PR should be to rewrite the script in Python instead of Perl, and that 
would be on master only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

Github user sverrirab commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-214783340
  
do you want this change as a new PR against master or just the rewritten 
script in python on master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-214735227
  
If this is broken right now and this fixes it, LGTM. But we should really 
ditch Perl and rewrite in Python or Bash.

Can you afterwards submit a PR against master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

Github user sverrirab commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-210485675
  
I agree that this is not a good approach but it is the current one and it 
is broken.  How about we commit this fix and I submit a new PR to master with a 
new python script?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-210018290
  
@sverrirab how much effort would it be to port to Python?  That seems far 
preferable for two reasons.  First, as @eriweb rightly points out, it is a 
large dependency to take on for such a small script.  Second, Python and bash 
are our scripting languages of choice.  It does not seem sustainable to add 
runtimes/libraries for every scripting language people might want to use.  Such 
sprawl will not only lead to bloat, but a system that fewer and fewer people 
can maintain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[eriweb]

Github user eriweb commented on the pull request:

https://github.com/apache/cloudstack/pull/1495#issuecomment-210016535
  
Quite horribly that we need those modules for a simple perl script of 58 
lines (including license header and empty lines). Not related to your PR 
though, but a good candidate to be rewritten in bash or python


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

[sverrirab]

GitHub user sverrirab opened a pull request:

https://github.com/apache/cloudstack/pull/1495

Add perl-modules as install dependency for cloudstack-agent

Required to run perl scripts that configure networking for VMs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack 
pr-install-perl-modules-on-agent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1495.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1495


commit 6d6bd510c2f5dc3fe076183379388521a55f95fe
Author: Sverrir Berg 
Date:   2016-04-13T16:48:31Z

Add perl-modules as install dependency for cloudstack-agent

Required to run perl scripts that configure networking for VMs.  That 
script fails silently if this is not installed.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---