[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

2015-07-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/595 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

2015-07-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/595#issuecomment-121843873 I browsed the code and found out that this templateSize = int(int(templates[0].size) / (1024**3)) was already been used in other places. So, your changes

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

2015-07-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/595#issuecomment-121929346 LGTM (we could decide to make this a generic macro type of construct so we guarantee unified behavior. on the other hand this is not building a rocket...) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8639:fixing calculation mistak...

2015-07-15 Thread nitt10prashant
GitHub user nitt10prashant opened a pull request: https://github.com/apache/cloudstack/pull/595 CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_doma… test result = Test secondary storage limit of domain and its sub-domains ... === TestName: