[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido closed the pull request at: https://github.com/apache/cloudstack/pull/985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218998186 Closing this one in favor of #1545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-12 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218846952 This failed during compiling: ``` [INFO] Apache CloudStack Plugin - Hypervisor KVM . FAILURE [11.036s] ``` Here is the error ```

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218699781 Thinking about closing this PR and coming up with two new ones. One which only adds the channel and installs Qemu Guest Agent in the SSVM. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-12 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218667408 @swill Yes, it does. It install the Qemu Quest Agent inside the SSVM. It doesn't hurt to do that already, it is just that the libvirt-java bindings don't allow

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-11 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218651517 Does this require a change to the system VM template? I am pulling this in for testing now... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-02 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-216216953 @rhtyd Done! Rebased against master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-02 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-216201171 @wido thanks for the feature, can you rebase against latest master and push -f; update on the state of the PR We should have this feature.

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-05-02 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/985#discussion_r61726188 --- Diff: systemvm/patches/debian/buildsystemvm.sh --- @@ -389,6 +389,8 @@ packages() { chroot . apt-get --no-install-recommends -q -y --force-yes

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-04-26 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-214733641 I just rebased the commit against master, but still waiting on libvirt-java. Really think we should fork libvirt-java to get this fixed. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-01-17 Thread nislim
Github user nislim commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-172307572 Any progress on getting the patches into upstream libvirt-java? @wido --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2016-01-17 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-172309253 @nislim No, not really. The people at libvirt-java aren't the fastest. Thinking about forking it into CloudStack itself. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-30 Thread NuxRo
Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-160654716 Ok, godspeed. With a bit of luck perhaps we'll see this somewhere in 4.7.x? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-30 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-160649027 Still working on this one. However, I need to get stuff into libvirt-java upstream. Working on that here:

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-13 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-156360759 @ustcweizhou Yes, it does. See the patches I posted above. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-12 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-156212769 @wido nice, I will test it. does this need the change on libvirt-java ? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-11-09 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-155098762 I justed pushed a new commit which uses libvirt-java for the communication with the Guest Agent. The build will fail since this patch for libvirt-java has not

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-30 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152461778 @wido ja, you got it. The issue happened on a host running with Ubuntu 12.04 (QEMU 1.2.1 and libvirt 0.9.13) There is no issue on Ubuntu 14.04 (QEMU 2.0.0

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-30 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152462216 @wido by the way, I just remember I have implemented some codes for qemu-guest-agent support , based on cloudstack 4.2.0 maybe. It is not fully tested. I

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-30 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152460936 @ustcweizhou Which version of libvirt are you using? If you use libvirt 1.0.6 or newer, you can omit the path='...' attribute of the element, and libvirt will

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-30 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152494985 @ustcweizhou @remibergsma I just pushed a new version of the commit. On Ubuntu AppArmor needs to be disabled since the default profile for libvirt doesn't

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152183473 I have same issue with Remi, there are two virtio-serial in the vm definition. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152193618 by the way, for user vms, I think it is better to add the field in vm_instance/user_vm or zone/cluster/global setting to determine if the vm is qemu guest agent

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152187084 succeed after the following change: diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152191665 that is good idea. then we need to rebuild systemvm template with qemu-guest-agent --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152188711 Hmm, ok. That should be allowed. Since we want the Guest tools also to be supported on SSVMs to control them properly. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152157162 @borisroman Could you give this PR a spin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152161769 @wido I will also test it again today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-29 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152332158 uservm can not start 2015-10-29 21:04:38,017 WARN [resource.wrapper.LibvirtStartCommandWrapper]

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151836172 @remibergsma Hmm, was SELinux enabled on that system? Can't see any reason why it wouldn't work. All the directories exist. Do you by any chance have the XML

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151832340 @wido Thanks for working on this, awesome! I was testing this PR and found that the SSVM and CPVM systemvms do not start properly. This is the error:

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151838470 Hi @wido : SELinux is off: ``` [root@kvm1 channel]# getenforce Permissive ``` The generated XML: ``` 2015-10-28

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-28 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-151871826 @remibergsma Ok, that is odd. A proper XML should look like this: ``` ```

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

2015-10-27 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/985 CLOUDSTACK-8715: Add VirtIO channel to all Instances for the Qemu Gue… …st Agent This commit adds a additional VirtIO channel with the name 'org.qemu.guest_agent.0' to all