Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-216191628
@kansal please rebase against latest master and push -f, update on status
of your PR
tag:easypr
---
If your project is set up for it, you can reply to this
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-212767205
@jayapalu Will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-212767005
@kansal code LGTM can you please add the API response output so that we can
push this PR.
---
If your project is set up for it, you can reply to this email and
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-189993774
Hello @kansal
I think you just should test the possibility of setting the domainName as
null and see what happens.
With that tested,
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-187574951
Can someone else review this as well? Already have unit test cases in the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-186823236
This looks like a sensible fix. Code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/858
CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRecâ¦
â¦ords does not return domain - Fixed and tests added
Problem: Only domainid is returned by usageReports API
