[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/994 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user pvr9711 commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-166879847 @remibergsma can you please merge this in? thanks, Raja --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153301418 this has two lgtm but no report of tests executed. As this is only test code I'll recreate an environment and give it a spin. --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user nitt10prashant commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153285936 LGTM based on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user pritisarap12 commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-153302400 Test Result: Test events table ... === TestName: test_01_verify_events_table | Status : SUCCESS === ok

Re: [GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

This is very small change related to list validation and it looks good. LGTM!! On Wed, Oct 28, 2015 at 11:28 AM, bhaisaab wrote: > Github user bhaisaab commented on the pull request: > > https://github.com/apache/cloudstack/pull/994#issuecomment-151733973 > >

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/994 CLOUDSTACK-9001: Modifying snapshot results validation Currently snapshots results validation is based on length of snapshot result but if snapshot creation fails then None type object

[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/994#issuecomment-151733973 Officially we're over 9000 :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does