Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-153013812
FYI: Running tests on this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-153125197
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-153126593
ran the same tests as Remi and they are past the vpc bit so it LGTM. There
is some discussion on the quality of the messages on the commits @bvbharatk .
Do
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1020
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/1020
CLOUDSTACK-9016 Fail to create VM instance within VPC
bug link https://issues.apache.org/jira/browse/CLOUDSTACK-9016.
CS doe not allocate the ip of the form x.x.x.1 to a guest VM. We
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-153074432
FYI: Also running tests in this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-152970832
Thanks, guys... and also thanks for the tests!
Will test it as well.
Cheers,
Wilder
---
If your project is set up for it, you can
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-152963507
Hi,
Adding Sanjeev's commit which tests this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-152963577
Test Results:
test_21_deploy_vm_with_gateway_ip (integration.component.test_vpc.TestVPC)
... === TestName: test_21_deploy_vm_with_gateway_ip | Status :
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-152996320
@bvbharatk Could you sqaush the commits, as they fix a single failure!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-152985217
@sanju1010 ,
What test did you run? I did a search for
"test_21_deploy_vm_with_gateway_ip" in all *py files and could not find
anything.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1020#issuecomment-153000625
@wilderrodrigues test_21_deploy_vm_with_gateway_ip is part of this PR,
what else are your looking for and where are you ooking for it?
---
If your project
12 matches
Mail list logo
