Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-162337898
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1049
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-158901139
@wido @DaanHoogland @wilderrodrigues Did any of you run the unit test and
did they pass? If so, please paste output. After this, OK to merge?
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-158901032
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-158917040
@remibergsma this has probably been laying around to long. I did run unit
tests and passed them but now compilation doesn't even succeed. I will put it
back
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-158924625
@remibergsma : that was a fluke, it does compile and run unit tests now???
```
[INFO]
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-157673706
@wilderrodrigues @wido can you review. The test keeps giving an exception
but the destroyed suystem vms come back without problems and the test suite can
even
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-157671208
As for ```test_09_destroy_ssvm``` the exception is a false positive due to
timeout. s-1-VM is destroyed and s-58-VM comes back but the timeout is reached
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-157306100
most network tests passed:
```
Test to create Load balancing rule with source NAT ... === TestName:
test_01_create_lb_rule_src_nat | Status : FAILED
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-157030796
running the integration tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-155381918
I will build this PR locally to make sure Maven runs the unit tests
successfully.
Cheers,
Wilder
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1049#issuecomment-155347860
Since all tests are still passing and based on the code a LGTM from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear
12 matches
Mail list logo
