Github user dsclose closed the pull request at:
https://github.com/apache/cloudstack/pull/1063
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-157678223
CLosing this pull request as the patched script is already deprecated.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156414832
@DaanHoogland That's already being done by @wilderrodrigues. Therefore this
one is obsolete.
---
If your project is set up for it, you can reply to this email
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156368254
@ustcweizhou @dsclose
Dude, this script is not used anymore! Please test it with maven, or
manually, and you will see that it doesn't apply.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156382390
@dsclose
Scripts not in use since 4.6.0:
```
public static final String FIREWALL_EGRESS = "firewall_egress.sh";
public
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156379177
@dsclose, please have a look at:
```
./cloud-systemvm/patches/debian/config/opt/cloud/bin/configure.py
```
Cheers,
Wilder
---
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156384240
@dsclose Thanks for your PR, it shows support! As the script is not in use
anymore, would you close the PR?
---
If your project is set up for it, you can reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-15648
@borisroman @dsclose how about changing it to a pr that removes the script
;)
---
If your project is set up for it, you can reply to this email and have your
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156118661
LGTM
the similar issue happened several times in our scripts.
We should use more precise expression when we use sed/grep, etc
---
If your project is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1063#issuecomment-156119598
@wilderrodrigues Are these scripts still used in master/4.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
10 matches
Mail list logo
