Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-161242475
today one of my nodes was rebooted unexpectedly, I got the same error
2015-12-02 09:59:53,224 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl]
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157648979
let's get this merged. I need no intergration tests for this improvement. a
disect of ```updateRoutersRedundantState``` to make the bit that is fixed and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157409023
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157389878
Hi @ustcweizhou,
Okay, I understood. Have you prepared a test to cover it? I mean, we need a
test that deploys a DC, creates a redundant VPC, adds
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157485350
@wilderrodrigues @remibergsma @DaanHoogland
this issue indeed happened in my testing environment. After investigation,
I found the node was shut down
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1073#issuecomment-157320534
code review done: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-156985363
@ustcweizhou Can you please make this PR against 4.6 branch? After merge it
will be fwd-merged to master. Thanks!
---
If your project is set up for it, you
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1073
CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks
This issue happened when the KVM nodes is down.It might also happen when
the cloudstack-agent is killed unexpectedly.
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-156991846
@remibergsma #1073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ustcweizhou closed the pull request at:
https://github.com/apache/cloudstack/pull/1059
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1059
CLOUDSTACK-9055: fix NPE in updating Redundant State of VPC networks
You can merge this pull request into a Git repository by running:
$ git pull
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-155740109
@ustcweizhou
Please, steps to reproduce/test your PR. Also, write a bit about how you
got into this issue in the PR description. In addition,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-155741147
LGTM by code inspection. The issue is obvious and the solution as well. I
do agree with @wilderrodrigues that permanent validation of the issue is
needed. In
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1059#discussion_r44523082
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1015,7 +1015,7 @@ protected void
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1059#issuecomment-155763566
@wilderrodrigues @DaanHoogland This happened when one of nodes is down. I
think it will happen when the cloudstack-agent is stopped or killed.
---
If
16 matches
Mail list logo
