[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1072 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-20 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1072#issuecomment-158335845 The change makes sense and the upgrade was tested by @remibergsma. LGTM :+1: Cheers, Wilder --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-19 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1072#issuecomment-158053349 LGTM, did an upgrade from `4.4.4` to `4.6.1-SNAPSHOT` and that worked now with only the `4.6` template registered. This was done with XenServer. ```

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156984124 @remibergsma @wilderrodrigues @karuturi is anything to be done with this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156984574 @DaanHoogland Yes, please make this PR towards 4.6 please. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1072 CLOUDSTACK-9057 remove old system vm upgrade code You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1061 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156988390 #1072 contains this code to be merged on 4.6 (and rebased on post-release commit) --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-13 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156365263 I will test the upgrade, @DaanHoogland and LGTM afterwards. Cheers, Wilder --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-12 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-156122612 Since this code is only needed if you upgrade to `4.5` not when you hit this code if you upgrade from say `4.4` and jump forward to `4.6`. This code is still

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-11 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1061#issuecomment-155809389 LGTM that is what we did for previous versions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9057 remove old system vm upgr...

2015-11-11 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1061 CLOUDSTACK-9057 remove old system vm upgrade code the upgrade step to 4.5 system templates is removed for 4.6 in this. validation would be to install any 4.4.2 or lower version and