Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-222335221
### ACS CI BVT Run
**Sumarry:**
Build Number 76
Hypervisor xenserver
NetworkType Advanced
Passed=72
Failed=1
Skipped=3
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-216208576
@pritisarap12 please modify the test to be able to run on basic zone as
well.
rebase against master thanks
---
If your project is set up for it, you can
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-190057225
Changed the tags to advanced zone:
Testcase result:
Check Netmask value in database ... === TestName:
test_01_netmask_value_check | Status :
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-189233999
-1
This test is not passing on a basic zone. In basic zone we don't list the
network cidr in list network response. So test is failing at line no: 163. It
Github user pavanb018 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-189116369
I have reviewed the code and it looks good to me as per the code review.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-185550931
Updated the testpath with review comments:
--Validation of netmask
--check it is from correct CIDR
---
If your project is set up for it,
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/1245#issuecomment-185550227
Test result after modifications:
Check Netmask value in database ... === TestName:
test_01_netmask_value_check | Status : SUCCESS ===
ok
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1245#discussion_r51685979
--- Diff: test/integration/testpaths/testpath_netmask.py ---
@@ -0,0 +1,152 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1245#discussion_r51686104
--- Diff: test/integration/testpaths/testpath_netmask.py ---
@@ -0,0 +1,152 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/1245
CLOUDSTACK-9168: Testpath to check if wrong value is inserted into nics
table netmask field when creating a VM
Testcase Result:
Check Netmask value in database ... === TestName:
10 matches
Mail list logo
