Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220631924
Ok, thanks @nitt10prashant. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220521199
@swill i do not see any comment on parent ticket CLOUDSTACK-8676 , i have
asked Sateesh to update the ticket , will update the PR as soon as i hear from
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220515109
@nitt10prashant any update on this one? I am very close to freezing, so I
figured I would check in. Cheers...
---
If your project is set up for it, you can reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-216575327
@nitt10prashant no problem. Thanks for the work. I just want to remind
you that the 4.9 release will be frozen on May 16th, so if you want to get it
into that
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-216513459
@swill thanks for your comment and time , it seems the code is not in the
master for which i have written the test script , it will take another 2 weeks
to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-215184791
@nitt10prashant I have to admit, I am confused on this one. I have the
latest Marvin installed that is generated when building this PR.
```
Installing
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-214793885
My CI runs the following command after it builds ACS, so it **should** be
using an upgraded Marvin, but I did see some messages about `--allow-external`
being
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-214660883
@swill seedTemplateFromVmSnapshot is new API got introduced with this
feature , if marvin installation is up to date it should have this API
@bvbharat can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-214495424
### CI RESULTS
```
Tests Run: 0
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-214337105
Based on the code review, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-213424673
@swill thanks for comment , i just did a force push
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-213408951
I need one more LGTM code review on this one. I will try to test this in
my lab today. Can you do a force push of this PR again to kick off jenkins so
we can get
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-213277092
@cloudsadhu @pavanb018 @GabrielBrascher @sanju1010 can you please test this
PR
---
If your project is set up for it, you can reply to this email and have
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-205684992
LGTM based on the code review !!
Please squash the commits into single commit.
---
If your project is set up for it, you can reply to this email and
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-198314365
@GabrielBrascher @sanju1010 i have removed redundant code
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-194406283
### ACS CI BVT Run
**Sumarry:**
Build Number 65
Hypervisor xenserver
NetworkType Advanced
Passed=99
Failed=13
Skipped=3
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55160508
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55160105
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55153415
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r54070462
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r54068802
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF)
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1417
CLOUDSTACK-9289:Automation for feature deploy vm from vmsnapshot
Automation for deploy vm from snapshot .
1-Test to create VM from vm snapshots without data disk
2-Deploy vm from
22 matches
Mail list logo
