Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-215303942
Sorry for the delay on this one guys. I think this one is ready now...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-214542430
LGTM for code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-214417865
@jburwell can I get your LGTM? I will run CI on this again today because
some code has changed since the last run.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-211563367
@abhinandanprateek, I believe you are away this week, but can your address
@jburwell's comments when you have a chance. Thanks.
---
If your project is set up for
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59934099
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59155288
--- Diff: test/integration/component/test_host_maintenance.py ---
@@ -0,0 +1,325 @@
+# Licensed to the Apache Software Foundation (ASF)
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59152218
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r59152198
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207146770
@swill just reviewed.
@abhinandanprateek I have a few more comments to be addressed on the test
cases.
---
If your project is set up for it, you can
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58965582
--- Diff: test/integration/component/test_host_maintenance.py ---
@@ -0,0 +1,325 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58965445
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58965346
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58964900
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58964733
--- Diff: tools/marvin/marvin/lib/utils.py ---
@@ -520,4 +520,22 @@ def verifyRouterState(apiclient, routerid,
allowedstates):
if
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207111301
I have gone through the code, it LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58953686
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207109385
@abhinandanprateek tests have passed, thanks for the updates. Can you do a
`push -f` to kick off a Jenkins run so we can try to get this PR all green.
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r58952716
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207107811
## CI RESULTS
### 84/85 TESTS PASSED
The test that failed is a test that commonly fails in my environment and
has been
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-206227732
@swill if it is possible to run
integration/component/test_host_maintenance.py first than please do that as it
is a new test added for this fix, followed
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205892559
@abhinandanprateek slight delay. I am going to blow away my CI setup and
reinstall it now to get it running on SSD drives so I can better parallelize my
tests.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205885703
@abhinandanprateek: Thank you. I will run the whole set of tests against
it again tonight. I have to let the current tests finish and run this on its
own because I
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205780575
Updated marvin test to use the builtin template. @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205672352
On comparing test execution times with macchinina Vs Centos builtin
template I did not find much of a difference. So modifying the test to go with
the
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205624341
@swill In my environment I am using macchinina templates for testing. These
are not there by default but are pretty handy in testing due to their small
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205473828
### CI RESULTS
**HAS FAILURES, NEEDS WORK!**
Please accress the following issue.
```
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205117865
@cristofolini @swill rebased the PR, up for CI now, Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205047143
@abhinandanprateek would you mind rebasing to current master so I can test
this in my CI? Thanks...
---
If your project is set up for it, you can reply to this
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-20457
@abhinandanprateek Looks like jenkins found some problems with your index.
I'd suggest rebasing against the current master making all the needed merges
and
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-203249781
Output from marvin test:
TMP=/tmp
CLOUDDIR=/root/cloudstack-apple
mkdir -p /tmp/simulator/smoke/misc
nosetests --with-xunit
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r57835178
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1454#discussion_r57714466
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -2112,11 +2112,13 @@ private boolean doCancelMaintenance(final long
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-202256571
Marvin test output:
root@ccp:~/cloudstack(host-maint)# ./host_maint.sh
++ date
+ echo Mon Mar 28 11:47:45 IST 2016
Mon Mar 28
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-202221938
@jsb added the marvin file and reverted to pre-commit formatted code.
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-202217738
@abhinandanprateek I don't see the Marvin test case in the PR. Have you
pushed the latest commit?
Also, most of the changes seem to be formatting changes
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1454
CLOUDSTACK-9323: Fix cancel host maintenance canâ¦
so that if maintenance is cancelled the host come back to normal state
gracefully.
Added marvin tests for host
37 matches
Mail list logo
