Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219616568
@swill alright, I'll squash them and open a new PR that could be reviewed
merged later
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219555128
@rhtyd I reverted this in master to hopefully unblock my CI environments
from failing as I am basically at my freeze date. Would you mind putting the
above commits
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219551825
I think I am going to have to revert this PR because it seems to be
responsible for the `addHost` issue I am having in all my CI environments while
doing DeployDC.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218943901
PR that aims to fix CPU issue -
https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218943044
@rhtyd Sounds good. Thanks for taking a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218942524
@kiwiflyer thanks, I think I've found two issues -- I'll tag you on another
PR, please test that in your lab and share if that fixes your CPU issue. /cc
@swill let's
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218776521
@rhtyd With the agent in trace mode, I see this scrolling through very
rapidly:
2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection]
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218774260
@rhtyd I have had a couple independant reports of CPU going to 100% with
this patch and the problem not existing if they revert this PR (along with
#1534).
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218763389
@rhtyd I'll work on pulling some trace logs and a debugger on the agent if
the trace logs don't show anything.
For reference, These patches were on our QA
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218656836
@kiwiflyer along with this patch, have you also applied the optimization
patch #1534 (make sure to apply the patch on both mgmt server and KVM agent) ?
We can debug
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071
No worries. ð I am really short on sleep, but I was pretty confident.
:P
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218520703
Sorry, I confused PRs. Please ignore my last comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246
@nvazquez I don't think #1539 is related to this PR. I think this one has
completely separate issues...
---
If your project is set up for it, you can reply to this
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218514854
@rhtyd @kiwiflyer @swill a PR for fixing the problem #1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922
---
If your project is set up for it, you can
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890
@rhtyd We're still seeing some odd behaviour related to the agent with this
PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 100%
cpu on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217286830
@swill the NioTest is a unit test and will only run during compilation. If
you hit any issues, feel free to revert the commit with some details on how I
may be able
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217272766
I confirmed that reverting this PR locally does fix my DeployDatacenter
issues.
I did an initial test with #1534 and it did get past the DeployDatacenter
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217270975
@swill sure thanks, please try with PR #1534 and if you still hit the
issue, please revert the commit locally first; run against your environment and
confirm that
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217252920
@rhtyd I have some bad news on this PR. I have been having issues in CI
ever since this got merged into master. When the tests don't run (and fail
which causes the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227342
Thanks, will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217225573
@swill I'm pushing a fix for you.
The initial value is 0, as clients send data it's incremented by 1. At the
end it's expected that total number of data sent
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227191
In my lasts run, not a single test passed in the time frame something is
wrong. Previously it was failing on 4/5, but this time it timed out without a
single test
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217226167
@swill I've ran my tests, please review and merge this --
https://github.com/apache/cloudstack/pull/1534
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217220334
@rhtyd but `totalTestCount = 5` and I don't think that `completedTestCount`
will ever be larger than `4`, so I don't know how that check could be right...
---
If
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62219725
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207167
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207228
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase;
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188135
@rhtyd I am still having problems with the tests in this PR, but now it is
in master.
This is causing builds to fail...
```
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188537
Is there a reason we need to spend 5 minutes waiting for this test every
build?
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216581383
Perfect, this one is queued up to be merged... Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216489209
@swill all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216421909
@swill forced pushed; the Jenkins server is not reliable -- as long as
Travis is green we are alright; the only additional check Jenkins does is the
rat check, which
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216382896
@kiwiflyer,
My testing with this patch - if you have at least several hundred KVM
nodes connected to 2 MS via VIP and take 1 MS down, you will notice
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216378613
Thank you @kiwiflyer. ð
@rhtyd can you force push this PR again to try to get Jenkins green?
Thanks... Otherwise this one is ready...
---
If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216375175
I pulled this into a hardware lab on 4.8.1. I setup a number of fake
clients and hammered 8250. Prior to the patch the agents end up in a
disconnected state
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216298669
No worries. Thanks... I also am a bit behind. I apparently have to just
assume I won't get any work done on mondays. :P
---
If your project is set up for it,
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216296997
@swill I'm a bit behind. I'm building this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216289074
@kiwiflyer do you have test results on this one? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216228508
This PR is ready for merge, /cc @swill
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215818023
LGTM for code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215815079
thanks @kiwiflyer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215741459
@rhtyd - We'll pull this in for functional testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215675646
@swill can you try again with your CI?
@agneya2001 @jburwell @wido @kiwiflyer @nvazquez @DaanHoogland and others -
please review and share your LGTM, thanks
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215350128
@swill there are in total 25 malicious clients that can block for 60s for
all 5 (max.) server worker threads; so worst case we should have waited for at
least
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215310531
BTW, I built with `-T 2C`, if that is relevant to help you understand why
it failed...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-215309861
Failed to build.
```
---
T E S T S
---
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-214432357
@swill done, though as I mentioned in the comments above the test that
failed in last travis run is a component test and fails on master too (i.e. not
related to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-214412952
I will run CI on this today. @rhtyd can you force push again to see if we
can get all green lights. @jburwell I see you have been active on this PR,
does it have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-214252922
All tests passes, except for a test that runs only on simulator that
sometimes passes, sometimes fails. This issue is due to master and not specific
to this PR:
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-213327217
@jburwell @GabrielBrascher @rafaelweingartner @swill if you're done with
review, LGTM please or share what else should be fixed. Thanks.
---
If your project is
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-212284556
@jburwell fixed use of test timeout within \@Test annotation
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-211261793
@swill I've fixed the outstanding issues, can you run your CI on this and
help merge? thanks
---
If your project is set up for it, you can reply to this email
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59920010
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59918834
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,215 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-210576373
Thanks all for the review, I've update the commits; please re-review and
advise other outstanding issue. Thanks again.
---
If your project is set up for it, you
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59917981
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915385
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915315
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915248
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915144
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59914101
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913697
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913436
--- Diff:
utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java
---
@@ -94,7 +94,7 @@ public void wakeupNotExisting() {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913672
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913051
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913073
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59912710
--- Diff:
utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java
---
@@ -94,7 +94,7 @@ public void wakeupNotExisting()
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59912439
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59900221
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59900296
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59900210
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient)
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59894203
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59892756
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59799743
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59795416
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59792529
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59791280
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59790778
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase;
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-210103368
I've created two commits to show: (1) test to prove denial of service
behavior due to blocking main IO loop, (2) the fix (as mentioned earlier long
term fix would
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-209896417
- Tested against KVM, mgmt server - KVM links and clustered management
server
- NioTest modified to have multiple clients against a server instance with
just
82 matches
Mail list logo
