Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219105793
Awesome, thanks guys. I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219033610
@swill This one is green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219027354
LGTM, running this in prod for about a month now. See link above for
screenshots.
---
If your project is set up for it, you can reply to this email and have
GitHub user NuxRo reopened a pull request:
https://github.com/apache/cloudstack/pull/1520
CPU socket count reporting correction
CPU socket count reporting correction
From
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
You can merge this pull
Github user NuxRo closed the pull request at:
https://github.com/apache/cloudstack/pull/1520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-218793268
@NuxRo I have pushed fixes to both Jenkins and Travis this morning. Can
you close and reopen the PR to kick off the Jenkins and Travis runs again.
Thanks...
---
GitHub user NuxRo reopened a pull request:
https://github.com/apache/cloudstack/pull/1520
CPU socket count reporting correction
CPU socket count reporting correction
From
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
You can merge this pull
Github user NuxRo closed the pull request at:
https://github.com/apache/cloudstack/pull/1520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-218365187
@NuxRo can you close and reopen this PR to force Jenkins to kick off a run.
It has been hung in this state for days. I know you can't easily `amend` and
force
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217514394
I am comfortable not running CI on this one given the scope of the change
and the manual tests that have been run. This one is ready now. We need this
force pushed
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217507357
LGTM (code review)
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217485432
We have rolled this patch in our lab and verified that it does indeed
report the number of sockets correctly. Based on testing this LGTM.
Please do a force
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217475012
Can we get another code review on this? Also, Jenkins seems to be hung,
can we either close and reopen the PR or do a force push to kick it off? Thx...
---
If
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-217094836
I'd appreciate it if someone else could do it, I do not have the setup to
perform more advanced github operations right now, other than the UI.
---
If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-216230034
@NuxRo thanks, please rebase and squash to a single commit
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215143364
Great, thanks @remibergsma. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215143007
@swill more details here:
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-215124694
@NuxRo can you do a force push to kick off jenkins and travis again. Also,
can you show this change fixes the behavior with a screenshot or something. I
don't
GitHub user NuxRo opened a pull request:
https://github.com/apache/cloudstack/pull/1520
CPU socket count reporting correction
CPU socket count reporting correction
From
https://github.com/MissionCriticalCloud/cosmic-plugin-hypervisor-kvm/pull/16
You can merge this pull request
19 matches
Mail list logo
