Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-199926708
@rodrigo93 have you built this PR successfully?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-197832134
Sorry for the delay to answer.
Hi @rafaelweingartner , thanks for the suggestion. I will revise my PR and
do the proper changes.
@syed I am not sure
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-196448464
@rodrigo93 Do you know why we have `Void` return types? I've seen them and
not sure why they were added.
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-196447656
@rodrigo93 you removed the return type Object (Void) to void; therefore,
you have to fix those methods usage, such as the one at line 202 (
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-196020657
Squashed last 2 commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1439
Changed Void Methods to void
I have changed many "Void" methods to "void" since they have to return
null at the end and it has the same effect of "void" methods.
You can merge this pull
