Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/826
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-214812658
I think we are all set. I will add to merge queue...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-214812261
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-213135751
@swill you know I always do; files from the server project have been
changed. I would agree it is small and of low risk but I am not putting in the
analysis to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212963691
I am pretty comfortable with this change. We have had 2 manual tests to
validate the functionality and two LGTM votes. I am not sure this change
warrants a full run
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212836461
Tested these changes manually in my setup. Changes works fine. LGTM!!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212800418
Tested the vpn user configuration with one router down and one router up
and it is working fine.
LGTM
---
If your project is set up for it, you can reply to
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212777128
@jayapalu attached the screenshots:
https://cloud.githubusercontent.com/assets/4276209/14700575/17b9fb80-07be-11e6-84cb-b61d68816496.png;>
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212773238
@jayapalu Rebased. Please have a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jayapalu commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212754742
@kansal Can you rebase it once.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-143727275
@remibergsma Rebased against the master. Repro steps are as follows:
1) Create two VMs in new isolated networks, testnet1 and testnet2.
2) Enable VPN in
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-143590180
@kansal Thanks! Can you please rebase against current master? Then we can
run the tests.
How did you test this?
---
If your project is set up for it,
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-141897458
@jayapalu can you review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
13 matches
Mail list logo
