[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2016-03-19 Thread sanju1010
Github user sanju1010 closed the pull request at: https://github.com/apache/cloudstack/pull/1156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2016-03-19 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-197537506 Is this PR still relevant or did the changes in the other mentioned PRs make this PR outdated? If it is still active, please rebase the PR to get rid of merge

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2016-03-18 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-197701355 @swill, PR #1276 outdated this PR. So closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-166835953 Hi @sanju1010, @wilderrodrigues asked me to extend the test_vpc_vpn script and in the proces i added the other hypervisors.

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177 @sanju1010 Are you still working on this? It's currently holding us a bit because we need to do some work on this test as well. For instance, I

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@wilder, I am ok with it. You can take it over. One comment, is ostype "Other PV (64-bit)" valid for other hypervisors otherthan Xenserver? And vmware template format should be in .ova The one you have mentioned in the Services class won't work. On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-10 Thread Sanjeev N
@Wilder, forgot to mention, either we should also add template for LXC or skip the test for LXC. On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N wrote: > @wilder, I am ok with it. You can take it over. > One comment, is ostype "Other PV (64-bit)" valid for other hypervisors >

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
@terbolour, as per the previous logic in the test, it will register xenserver template for any hypervisor other than kvm and vm deployment fails for other hypervisors like vmware,hyper-v and lxc. So I was asking how we should handle this. On Tue, Dec 8, 2015 at 12:44 PM, terbolous

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936 Gotcha. We could add templates for the other hypervisors (vmware and hyperv) from http://dl.openvm.eu/cloudstack/macchinina/x86_64/ And remove the

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-08 Thread Sanjeev N
Thanks @michaelandersen, I will take those templates and make the test generic. On Tue, Dec 8, 2015 at 3:35 PM, michaelandersen wrote: > Github user michaelandersen commented on the pull request: > > https://github.com/apache/cloudstack/pull/1156#issuecomment-162837936

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread Sanjeev N
@michaelandersen, if we want to use that template it only works for kvm. So either we have to skip the tests for other hypervisors or make the similar templates for all other hypervisors as well. On Tue, Dec 8, 2015 at 2:00 AM, michaelandersen wrote: > Github user

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162797528 @sanju1010 it works for XenServer as well atleast, haven't tried VMware. But you'll have to change your script to adjust to the different output --- If your

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162522267 ping @sanju1010 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162545461 Hi Sanju, Isn't it the point of the test to verify this exact connectivity? But I any case I don't believe connectivity is the reason this

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162539384 Hi Remi, As I mentioned in my PR the second test failure is related to connectivity issues between the vms part of s2s vpn. It is not because of my

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread terbolous
Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162544664 @sanju1010 the error lies in the script due to different outputs. the test seems to use macchinina as template, which has the following output for ping: #

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162546287 :-1: Tests are failing, we need to fix it before we consider a merge, sorry. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162535442 Doesn't work for me either: ``` Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS === ok Test

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162520027 Just tested this on 4.6.1-SNAPSHOT with the command: ``` nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-07 Thread michaelandersen
Github user michaelandersen commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162651522 So removed my last comment about field 7 to 6. We need to choose 1 type of template os for both kvm and xen and base the test on that. @sanju1010: the

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-06 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-162342696 @sanju1010 Thanks for the PR. Can you make it PEP8 compliant again please? Most tests seem to create the offering the test needs. Isn't that a better

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-03 Thread sanju1010
Github user sanju1010 commented on the pull request: https://github.com/apache/cloudstack/pull/1156#issuecomment-161599503 Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS === ok

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-03 Thread sanju1010
GitHub user sanju1010 opened a pull request: https://github.com/apache/cloudstack/pull/1156 Fixed issues with test_vpc_vpn script There are few issues with this test file. Please refer to JIRA Ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9102 for details on the issues