Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1566#issuecomment-222551237
Looks good to me. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1566
Followup fix for #1162: Add support for not (re)starting server after
cloud-setup-management.
New version against #1330, opened against master.
```
Moving stop of management
Github user ProjectMoon closed the pull request at:
https://github.com/apache/cloudstack/pull/1330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-221846556
Closing to open against master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-216301175
We are still accepting bug fixes in 4.7 and 4.8, but all features should be
added to master. Anything merged into 4.7 or 4.8 will be forward merged up
through
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-216220520
@ProjectMoon thanks, please open against master; unlikely we'll do 4.7.x
4.8.x releases
---
If your project is set up for it, you can reply to this email and have
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-215979893
Right now I suppose I still need to make a unit test. And I guess also
re-open against 4.7.
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-215872240
Team,
Where are we currently on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-201243710
_Link to logs Folder (search by build_no):_
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
### ACS CI BVT Run
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-185671218
Also, forgot I was making a test case for this. Will update my agenda to
get this done.
---
If your project is set up for it, you can reply to this email and
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-185646057
PR updated to latest 4.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-175690469
LGTM, let's merge after some tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ProjectMoon commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-173869256
Perhaps I can make a small example test that starts
cloudstack-setup-management under systemd with both `--no-start` and without
it, showing the difference in
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171251852
2xLGTM, no test results. Did anyone verify this works?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171250460
LGTM, pinging @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171217574
complaining about a license, false positive:
server/test/com/cloud/event/ActionEventUtilsTest.java
---
If your project is set up for it, you can reply to
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171288280
I know, I said 'systemd install script'. I am not taking the time to test
this now. I can ask @davidamorimfaria . David?
---
If your project is set up for
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171282358
@remibergsma @ProjectMoon did himself, as I read it. This is a systemd
installation script it won't be touched by the integration tests. You are not
satisfied
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-171287727
@DaanHoogland This is not systemd, this is a python script to configure
management. Why don't we build an environment and try this script with its
parameters.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1330#discussion_r49442629
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -138,9 +138,8 @@ def checkHostName():
except:
pass
GitHub user ProjectMoon opened a pull request:
https://github.com/apache/cloudstack/pull/1330
Followup fix for #1162: Add support for not (re)starting server after
cloud-setup-management.
This is a follow-up fix for pull request #1162, which added a `--no-start`
option to
Github user davidamorimfaria commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-170898189
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ProjectMoon commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1330#discussion_r49445279
--- Diff: python/lib/cloudutils/serviceConfigServer.py ---
@@ -138,9 +138,8 @@ def checkHostName():
except:
pass
23 matches
Mail list logo
