[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1522 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215493805 its added to my merge queue. I need to get through this queue today, it is getting long now. :) --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215486826 @swill This is Ready to Merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215486284 Code is straight forward and makes sense. I validated it works in the lab. LGTM. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215463060 This change is pretty straight forward and it has been manually verified by @koushik-das in addition to the output originally posted by @nathanejohnson. I think

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-28 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215407693 LGTM. Verified in api.log that job id is getting appended. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-27 Thread kiwiflyer
Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1522#issuecomment-215248091 @nathanejohnson This is a nice addition that will enable easier tracing of events as we pull them into logstash. So those out there using async job calls should

[GitHub] cloudstack pull request: Log asynchronous responses in the api log

2016-04-27 Thread nathanejohnson
GitHub user nathanejohnson opened a pull request: https://github.com/apache/cloudstack/pull/1522 Log asynchronous responses in the api log Currently API responses for synchronous calls are logged, but asynchronous call responses are not. This pull request makes a minor