[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-06-01 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, thanks, I appreciate the effort! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 I gave one of my guys RPMs for master without this PR and he was able to reproduce the issue you have described. I gave him new RPMs for master including your PR and he got up and running

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, great, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 Ok, thanks for being on top of this. I will get this tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 Yes, that's what I was thinking, in my development setup (```mvn -pl :cloud-client-ui jetty:run```) it's working fine as well. But on our real test setups (```service

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 I will do some testing with installing from the packages and running as a service... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 I am running it with `mvn -pl :cloud-client-ui jetty:run > jetty.log 2>&1 &`. You are are starting it with `service start cloudstack-management` or something like that? --- If

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @swill, that's what I was afraid of. Are you running ACS as a service, or just running it like a development setup (through jetty)? Since that makes a huge difference. And yes, we are

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 Please close and reopen or amend and force push to kick off travis again... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded before cre...

2016-05-31 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1574 @nlivens `master` is frozen for the 4.9 release. I have not been having issues with this in my environment, so I don't think this is required for 4.9. Are you not able to use master

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222654633 @rhtyd, thanks for your quick review, handled your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222653613 In general, LGTM though it's up to general community acceptance. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159171 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159038 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65158988 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread nlivens
Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222642902 @rhtyd, @DaanHoogland, @swill, pinging you guys for an update regarding the Tomcat start up issue. This is related to #1553. I've also updated this in the mailing

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread nlivens
GitHub user nlivens opened a pull request: https://github.com/apache/cloudstack/pull/1574 Make sure that the DB drivers are loaded before creating connections You can merge this pull request into a Git repository by running: $ git pull https://github.com/nlivens/cloudstack