Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158018041
@karuturi Remi asked for a 4.6 based PR. Given some votes and if we don't
have an objections should I go ahead and merge on master?
---
If your project is set up
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158021203
@bhaisaab I'm OK with merging this to master now, but that will also mean
it will not end up in 4.6. I think @DaanHoogland already said that no new
features
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158021643
@remibergsma Agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157983748
+1 to merge on master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157987945
I would like to give a LGTM, but my JavaScript skills aren't that good.
The small Java changes look good to me.
---
If your project is set up for it, you can
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157988733
+1 have tried the feature and used bits of it in revamped quota UI.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158008482
@remibergsma rebased again the branch against latest master, created PRs;
4.6: #1090
4.5: #1091
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1038
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158027141
@remibergsma alright, merging on master now. If there is no objection, I
would like to merge this on 4.5 as whole, if that's not acceptable at least the
other
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158017542
Hi @bhaisaab
you should create PRs for (4.5 and 4.6) OR (master). Not for all the
branches.
Based on the discussion and votes above I think the decision
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158289806
+1, please merge
On 11/18/15 11:03 PM, Rohit Yadav wrote:
> Guys can we get some +1s on this, so let's at least merge on master? cc
>
Github user serverchief commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-158291609
The metrics UI is not really a major feature in my opinion. We are not
changing the core and any apis.
All we are doing is re-presenting already
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157971218
Guys can we get some +1s on this, so let's at least merge on master? cc
@wilderrodrigues @DaanHoogland @NuxRo @wido @abhinandanprateek and others
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157421614
@DaanHoogland Because @bhaisaab wants it in 4.5.3. Otherwise people will
upgrade from 4.5.3 to say 4.6.2 and lose a feature.
---
If your project is set up for
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157426767
hm, this is breaking our policy hard. I have some things of Wei's laying
around
---
If your project is set up for it, you can reply to this email and
Github user NuxRo commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-157428042
Right, so what now?
Can't we just postpone this till 6.7 and perhaps provide some easy patches
in the meanwhile for whoever wants to use in 4.5 and 4.6?
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-156986694
I've run this for some time and it is really cool, thanks @bhaisaab LGTM
If you consider back porting this to 4.5.3, then I think we should also
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-156989823
@remibergsma this is a very cool *feature*. why do you suggest it be put in
4.6?
---
If your project is set up for it, you can reply to this email and have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-155462713
Nice logo @bhaisaab :-)
@DaanHoogland see the capture
---
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-154399546
thanks guys, missed that. Should I do anything more then just run with this
change? an option some where? I am not seeing the metrix bottun in the zone
view.
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1038
Metrics views for CloudStack UI
FS:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Metrics+Views+for+CloudStack+UI
JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-9020
You
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1038#issuecomment-154067974
For screenshots, please see the FS:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Metrics+Views+for+CloudStack+UI
---
If your project is set up for it,
35 matches
Mail list logo
