Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-215079521
I am not seeing the issue on master. It appears that your issue may be
related to the Host(9) being unreachable. I would validate the connectivity is
all working
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-215041061
@milamberspace @swill @remibergsma @DaanHoogland, I am seeing a similar
issue on master: https://issues.apache.org/jira/browse/CLOUDSTACK-9370
I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199521648
Sorry, my bad. I have been disconnected for 3 days and my inbox has
exploded and I am trying to work my way through everything and my brain is a
bit fried. Sorry
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199519708
@swill Already merge to 4.8 (for next 4.8.1) and on master (4.9)
same commit id: 3eceb60f5ca8b86b3308243ae2905bbfbd54bc39
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199514658
Sorry, I missed that line in the comments. :) Thanks @ustcweizhou. I
will check and see if it has been forward merged. It should be if it hasn't
been, correct?
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199513826
@swill this PR has already been merged into 4.7 on 2016-01-23
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199512959
I am happy with this PR. I believe I should be merging into 4.7 and then
forward merging into 4.8 and master. I am sorry this is a bit off topic, but
should we be
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199448860
@DaanHoogland @remibergsma I don't want backport this fix, my (new) current
installation of CS is under 4.8, but this RV bug is coming with the new python
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791
@milamberspace No back porting please :-) Just upgrade to 4.7, it's a
painless 10min job.
---
If your project is set up for it, you can reply to this email
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199210638
@milamberspace I think we seriously need to consider if we are going to
maintain 4.6 as in the beginning of 4.7 many bugs were fixed on master and
later 4.7
Github user milamberspace commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-198946677
FYI
This PR fixes the bug CLOUDSTACK-9255
https://issues.apache.org/jira/browse/CLOUDSTACK-9255
(perhaps need to backport this PR on 4.6
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1356
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173871762
I see no harm in these changes and as they are putting related code closer
together it improves readability: LGTM
However I have a question: How is this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173863164
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173872641
@DaanHoogland It improves performance due to fact firewall rules are only
created (in memory) once we expect a change. If for example a dhcp lease needs
to be
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173915308
@boris, thanks. moving code to to be executed only conditionally is a very
good idea, this is even better then seemed at first glance :)
---
If your project
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173902852
@remibergsma already tested and code LGTM :+1:
We have this PR already running in out Beta environment, which is a copy of
our production
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1356
More VR performance!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance-wip
Alternatively you
18 matches
Mail list logo
