GitHub user GabrielBrascher opened a pull request:

    https://github.com/apache/cloudstack/pull/1443

    Remove unused code from XenServerStorageProcessor and change methods access 
level

    Remove unused code from 
"com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor" class and 
modify some methods access level.
    
    Remove unused methods:
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection,
    String)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection,
    StorageFilerTO)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand,
    DecodedDataObject, DecodedDataObject)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)
    
    
    change access level:
    - from public to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from public to protected:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from protected to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection,
    String, String, Boolean, int)
    - from protected to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection,
    String, String, String, String, String, String, Boolean, int)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GabrielBrascher/cloudstack lrg-cs-hackday-028

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1443.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1443
    
----
commit eb437b225a83bdcd114458145c83642944814e42
Author: gabrascher <gabrasc...@hotmail.com>
Date:   2016-03-19T18:49:47Z

    Remove unused code from
    "com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor"
    class and modify some methods access level.
    
    Remove unused methods:
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSRByNameLabel(Connection,
    String)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getNfsSR(Connection,
    StorageFilerTO)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.directDownloadHttpTemplate(CopyCommand,
    DecodedDataObject, DecodedDataObject)
    - 
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.execute(AttachPrimaryDataStoreCmd)
    
    
    access level:
    - from public to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftUpload(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from public to protected:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.swiftBackupSnapshot(Connection,
    SwiftTO, String, String, String, Boolean, int)
    - from protected to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.getSnapshotSize(Connection,
    String, String, Boolean, int)
    - from protected to private:
    
com.cloud.hypervisor.xenserver.resource.XenServerStorageProcessor.backupSnapshot(Connection,
    String, String, String, String, String, String, Boolean, int)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to