Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-214505566
@remibergsma bump. :) just a friendly reminder. what should we do with
this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-211417769
@remibergsma how should we handle this PR now that we have found references
to these files?
---
If your project is set up for it, you can reply to this email and
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209077230
I have created a jira ticket for this.
https://issues.apache.org/jira/browse/CLOUDSTACK-9345
Maybe we could close this PR, and then next
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-209020597
@rafaelweingartner +1 to remove all that stuff
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208903886
I also thought it was the HyperV agent; but, that agent is built in a
different way. I was going over the files, and it seems that is used to build
an
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208900500
might be just for the agent, I have never run it. I read about people
running it on windows but back in the days when i did it is was on cygwin.
---
If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208898455
you mean the ACS itself?
The whole ACS? For what I have seen of the code base, it does not seem to
work in Windows environments.
---
If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208897161
the windows install of acs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208896922
Is that "wix-acs" maven task executed?
What does it build?
I noticed it has as an output a file called "acs.msi", what is it?
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268
Isn't there references to these files? Forget the ones in `target`, but
the references in `cloudstack/scripts/installer/windows/client.wxs` should
probably be
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208812036
Yes, seems rather stupid to keep those :)
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208794882
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208591476
Can you either close and reopen or do a `push -f` to try to kick off
travis. I am confident in this PR, but I want everything green before we
merge... Thank you
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207570464
Remove unused files is always good. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207355341
:) still cleaning, good job.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-207251541
Travis error is unrelated obviously:
```
No output has been received in the last 10m0s, this potentially indicates a
stalled build or something wrong
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1475
Remove unused images
We really don't need this, do we?
Check your own cloud, it's there...
