Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216578573
My CI does not have the capability of testing this, so even if I ran CI it
would not cover this. I tend to agree that his is fine as is.
---
If your project is set
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216516629
@swill This has 2 x LGTM. Simple change and probably doesn't require any
additional CI IMO.
This is Ready to Merge
---
If your project is set up for it, you
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216513556
According to the explanation of @remibergsma, and the code changes : LGTM
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216435060
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216435050
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user imduffy15 commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216353475
I'm not familiar with that block of code, remi's changes and justification
seem fine though.
Some very oddly/badly worded variable names.
---
If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216227853
@karuturi @imduffy15 comments on the change, thanks
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1485
Set default networkDomain to empty instead of username
The 10th field of `createUserAccount` is `networkDomain` (See
`AccountService.java`) and it is set to a var named `admin`, which is
