Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-220023373
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-220023082
### CI RESULTS
```
Tests Run: 83
Skipped: 0
Failed: 0
Errors: 2
Duration: 8h 32m 12s
```
**Summary of the
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-216683077
@rhtyd rebased and squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-216224139
@resmo LGTM, please rebase against master and squash changes into a single
commit
tag:mergeready
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-215097877
@bvbharatk I am guessing you are still having some environment issues in
your CI or are these results correct? Thanks...
---
If your project is set up for it, you
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-195810182
### ACS CI BVT Run
**Sumarry:**
Build Number 83
Hypervisor xenserver
NetworkType Advanced
Passed=75
Failed=23
Skipped=3
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-193866958
Makes sense. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user glennwagner commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-193156160
Had a look ta your changes, PR LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-185628849
thanks for the explanation.
Your PR LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-185579250
Actually the logrotating is running every hour (by size), which can not be
done with logrotate time interval. We have had problems in the past filling up
/var (and /
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-185251677
Do we want to rotate logs only based on size?
What about using that âminsizeâ and the timestamp (daily)
configuration? I do not know the system
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/1414
SystemVM cleanups
from the logrotate docs
> size - With this, the log file is rotated when the specified size is
reached. Size may be specified in bytes (default), kilobytes (sizek), or
13 matches
Mail list logo
