Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-220094312
@swill yeah I've asked @anshul1886 few questions and waiting for answers.
Btw, since we're in a release/branch freeze, this feature PR need to be held
until 4.9.0 is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-220031084
@rhtyd can you work with @anshul1886 to understand what is going on here?
This is important as we are about to freeze master and cut 4.9. Thanks...
---
If your
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219942609
@swill @rhtyd I am facing permission denied exceptions for some APIs in UI.
Seems like they are after the merge of PR #1489.
---
If your project is set up for
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219922544
Ok thanks. I just wanted to verify. I don't think I can merge this
without integration tests against HyperV being run. My tests just show it does
not break other
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219919462
@swill Yes, PR is up to date. It was updated yesterday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219911314
I have seen this error with other PRs. I am not sure exactly where it
comes from. Out of curiosity, is the PR up-to-date in terms of rebasing?
I think this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219911051
### CI RESULTS
```
Tests Run: 81
Skipped: 0
Failed: 0
Errors: 1
Duration: 8h 06m 18s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-219791327
Can you run the following tests on this PR and post the results? I will
run my KVM CI against it to verify nothing is broken for other hypervisors.
```
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-216185699
@anshul1886 please re-base against latest master, update on current status
of your work/PR
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-132173995
@anshul1886 if the purpose is to ensure that the path returned doesn't
change, this seems perfectly aceptable to me. If people want to change the path
in the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-131768698
I don't see any test, we can not release this to the public without
limitation of warranty. extensive testing needs to be implemented to give any
degree of
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/351#discussion_r37174039
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -2294,7 +2292,7 @@ private void
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/351#discussion_r37174252
--- Diff:
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
---
@@ -978,14 +1025,58 @@ public JContainer
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-132072709
@DaanHoogland Updated the code with review comments.
Regarding unit tests I am identifying modules for which unit tests can be
written. But be aware that
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-131724787
@remibergsma Either we have to squash all commits to one commit or leave it
as it is. In squashing all commits to one I will put all the relevant messages.
These
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-131701094
@devdeep Did you LGTM on this? Were you able to test / verify it with a
hyper-v cluster?
@anshul1886 Can you look at the commits and see if you can
Github user devdeep commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-131683283
Changes looks good to me. @remibergsma Are you ok with these changes? I'll
go ahead and merge them then.
---
If your project is set up for it, you can reply to
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-131678148
Updated the code as per review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-130996684
Unit test which is failing is testing KVM code and is not related to any
changes in this file
---
If your project is set up for it, you can reply to this email
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-130973969
Removed the MigrateCompleteCommand as per review comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-129292846
@remibergsma,
Rebased the branch to latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-129040716
@anshul1886 Can you update the PR? It doesn't merge clean.
Anyone able to review Hyper-v?
---
If your project is set up for it, you can reply to this email
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-125090049
Rebased the code to latest master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user devdeep commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-122773398
I'll take a look and get back if I have any queries
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-121174974
@runseb These are false failures. The changes on which these tests are
failing are in Hyper-V agent so can be safely ignored as these tests are not
testing
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-117977973
@anshul1886 looks like it failed the tests. Can you check what's happening
and correct accordingly ?
---
If your project is set up for it, you can reply to this
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/351#issuecomment-109032779
Hi @anshul1886,
Thanks for the PR :-) Looks like quite some work!
I don't have a Hyper-V setup to test it.. Will ask around and see who can
help test
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/351
This branch implements the CSV and native HA support for Hyper-V
For design related details refer to
https://cwiki.apache.org/confluence/display/CLOUDSTACK/iSCSI+and+HA+support+in+Hyper-V.
28 matches
Mail list logo
