[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-05-26 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1499#issuecomment-221921405 @swill Sure can do, sorry for the delay, I haven't had much time lately but that will be done soon. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-05-25 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1499#issuecomment-221763535 Bump... @alexandrelimassantana this one has merge conflicts. Can you rebase and fix the conflicts? Thanks... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-05-19 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1499#issuecomment-220513799 @alexandrelimassantana this one has merge conflicts. Can you rebase and fix the conflicts? Thanks... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-04-18 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1499#discussion_r60035839 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -497,9 +506,7

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-04-18 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1499#discussion_r60035791 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -391,9 +395,15

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-04-17 Thread alexandrelimassantana
GitHub user alexandrelimassantana opened a pull request: https://github.com/apache/cloudstack/pull/1499 Undetected bug correct and refactor of the class NfsSecondaryStorageResource Im in process of rewriting the unit test for this class' mount method. Before I can do that, the