Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402502
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64397004
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64395993
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-221211912
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353975
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent)
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353084
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64352201
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-217442913
@DaanHoogland I am having surgery this afternoon, so I will be unable to
get it to it today (6 May 2016). I will try to put together a PR later this
weekend or
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-217370549
@jburwell Even when out of scope, your comments may make sense. please send
a pull request to my branch and we can discuss those.
---
If your project is set
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -216,10 +226,12 @@ public String getAdapterType() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282559
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -144,10 +151,12 @@ public String getAdapterType() {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282499
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282456
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282416
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1530
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1530
Vmdk findbugs
replacing #1351
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack vmdk-findbugs
Alternatively
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216515896
@rhtyd you are right, I rebased against master instead of 4.7, sorry, will
close and reopen against master
---
If your project is set up for it, you can
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216442417
@DaanHoogland I'm seeing a lot of commits, can you rebase against 4.7?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216225603
@rhtyd & @DaanHoogland I don't have the ability to test this as I have a
KVM setup, can one of you post some test results using VMware?
---
If your project is set
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216221100
@DaanHoogland can you rebase it once again and push -f
Once CI tested, we should be able to merge this cc @swill
tag:easypr
---
If your project is
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-206250177
+1 for code changes and based on the test report from @bvbharatk.
Since the changes are specific to VMware and the test results are for XS,
not sure how to
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-200074256
### ACS CI BVT Run
**Sumarry:**
Build Number 120
Hypervisor xenserver
NetworkType Advanced
Passed=106
Failed=12
Skipped=4
Github user DaanHoogland closed the pull request at:
https://github.com/apache/cloudstack/pull/1351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user DaanHoogland reopened a pull request:
https://github.com/apache/cloudstack/pull/1351
Vmdk findbugs
these are two of the findbugs errors coming out of our jenkins all the
time. The author seems to be unavailable so I kicked and screamed at it.
notice that this is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-176191880
Seems good to me looking at it. Don't know how to test it properly, but
code-wise the changes look sane to me.
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-176195149
LGTM, did not test it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1351
Vmdk findbugs
these are two of the findbugs errors coming out of our jenkins all the
time. The author seems to be unavailable so I kicked and screamed at it.
notice that this is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-172917596
note that jenkins isn't responding to the PR (so far)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
33 matches
Mail list logo
