[GitHub] cloudstack pull request: initial dockerization commit.

2015-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: initial dockerization commit.

2015-08-01 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/623#issuecomment-126909038 @karuturi , I haven't found a way to specify the release number at the ```docker build```. If there is a way I would use it so Dockerfiles would be same across

[GitHub] cloudstack pull request: initial dockerization commit.

2015-07-31 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/623#issuecomment-126582144 I was able to build the images locally. changes looks good. :+1: for the centos 6 and marvin, it is always taking 4.6 images from jenkins. Which means we

Re: [GitHub] cloudstack pull request: initial dockerization commit.

2015-07-30 Thread Pierre-Luc Dion
Hello dev@! I'm looking for another LGTM (real one, please read the PR) as replacement of Seb, PR #623 replace the PR #605 based on Seb's comments. Cheers, On Mon, Jul 27, 2015 at 4:52 AM, wido g...@git.apache.org wrote: Github user wido commented on the pull request:

[GitHub] cloudstack pull request: initial dockerization commit.

2015-07-27 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/623#issuecomment-125132961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: initial dockerization commit.

2015-07-26 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/623 initial dockerization commit. Initial PR for Dockerization of CloudStack. Important Changes: * scripts/vm/systemvm/injectkeys.sh: script execution will pass event if /dev/loop0