[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176045486 @runseb this was sent for master as the author intended, non-issue actually but would satisfy SonarQube from showing up redflags --- If your project is set up

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176114524 @runseb @bhaisaab I think this is worth a small but intensive discussion, preferably over a beer. What we are talking about is neither a bug nor a feature. We

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176114078 @runseb We could see it as a bug, but I agree with @bhaisaab that it is a non-issue that was "fixed" to make SonarQube happy. Fine to do that straight on

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176115753 @bhaisaab @remibergsma @DaanHoogland ok then, just checking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-176107957 Hi @bhaisaab I am genuinely asking because of the new release principles:

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-175689026 LGTM, merging based on comments and tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-175833323 Folks, I did not have time to fully test the new merging process from @DaanHoogland and @remibergsma but let's assume this is good to merge should this really be

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172533708 LGTM, UI seems to display OK. ![screen shot 2016-01-18 at 15 00

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172192646 sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1288#discussion_r49930663 --- Diff: ui/plugins/plugins.js --- @@ -16,7 +16,7 @@ // under the License. (function($, cloudStack) { cloudStack.plugins = [ -

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-172191734 @bhaisaab we do not have anything better the sonarqube atm. so let's listen to it. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1288#discussion_r48466763 --- Diff: ui/plugins/plugins.js --- @@ -16,7 +16,7 @@ // under the License. (function($, cloudStack) { cloudStack.plugins = [ -

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1288#discussion_r48466808 --- Diff: ui/plugins/plugins.js --- @@ -16,7 +16,7 @@ // under the License. (function($, cloudStack) { cloudStack.plugins = [ -

[GitHub] cloudstack pull request: trailing commas in javascripts removed

GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1288 trailing commas in javascripts removed According to SonarQube this is a bug on internet explorer. It is the only 'blocker' level issue in cloudstack. @abhinandanprateek (@agneya2001)

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-167496523 @bhaisaab did you check the internet explorer claim that sonarqube makes? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-167497445 @DaanHoogland no --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: trailing commas in javascripts removed

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1288#issuecomment-167405856 @DaanHoogland IMO, we don't have a javascript checkstyle or linter; and such things are non-issues, I would say either have a checkstyle like build step (like a