Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1421
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-217497179
any suggestions for how to test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216285170
How do I test this and verify it is working?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216273377
@remibergsma requires force push again. Travis timed out...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216224495
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216030620
Force pushed again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-215988060
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-187054205
LGTM, based on the code and the presented output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1421#discussion_r53593074
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
def __moveFile(self,
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1421#discussion_r53555783
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
def __moveFile(self,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1421#discussion_r53555684
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
def __moveFile(self,
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-186664554
Test result:
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1421
zip the processed json files so we save diskspace
Zip the processed json files and make sure they're unique (timestamp is not
unique).
You can merge this pull request into a Git
13 matches
Mail list logo
